Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficulty multiplier not accounted for correctly in playlist item display #29313

Open
ZenoG2 opened this issue Aug 6, 2024 · 6 comments
Open
Labels

Comments

@ZenoG2
Copy link

ZenoG2 commented Aug 6, 2024

Type

Cosmetic

Bug description

The difficulty shown is not affected by mod multiplier, unlike stable!

Screenshots or videos

image

image

image

Version

2024.731.0-lazer

Logs

compressed-logs.zip

@yesseruser
Copy link
Contributor

The incorrect rating also shows in the room's tile:
image

@bdach bdach changed the title Difficulty multipliers do not apply in Multiplayer Difficulty multiplier not accounted for correctly in playlist item display Aug 29, 2024
@ZenoG2
Copy link
Author

ZenoG2 commented Aug 30, 2024

This issue also applies to "difficulty range" in singleplayer.

0830.mp4

@bdach
Copy link
Collaborator

bdach commented Aug 30, 2024

@ZenoG2 that's a separate issue, separate issue thread please

@bdach
Copy link
Collaborator

bdach commented Sep 23, 2024

This one is sorta difficult to properly deal with because what happens when the user doesn't have the beatmap locally?

I can see two options here:

  • somehow get web to return the actual effective star rating including mods
  • fix this client-side ourselves, by requesting difficulty attributes from API and doing a local diffcalc

@ppy/team-web any thoughts on this?

@nanaya
Copy link

nanaya commented Sep 24, 2024

if the data is somewhere in the database then sure, osu-web can pass it along. Last I remember it's only for stable client related mods though? Or have lazer mods also been added?

@bdach
Copy link
Collaborator

bdach commented Sep 24, 2024

Yeah nothing has changed on that front, database only contains the attributes for mods that exist in stable.

I wonder if at some point we want osu-rank-lookup-cache to support lazer mods. Maybe that'd be a start to all of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants