Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osu!std hitsounds playing in osu!taiko editor when setting don object volume anywhere from 60 to 85 #29832

Open
ChromaCat248 opened this issue Sep 10, 2024 · 0 comments · May be fixed by #29970
Open

osu!std hitsounds playing in osu!taiko editor when setting don object volume anywhere from 60 to 85 #29832

ChromaCat248 opened this issue Sep 10, 2024 · 0 comments · May be fixed by #29970
Assignees
@bdach
Labels
area:editor audio ruleset/osu!taiko

Comments

@ChromaCat248
Copy link

Type

Game behaviour

Bug description

i couldn't test it with a different skin because i stopped being able to replicate the issue at all for some reason

Screenshots or videos

hitsounds.mp4

Version

2024.906.2-lazer

Logs

compressed-logs.zip
@ppy ppy deleted a comment from TryhardPickles Sep 13, 2024
@bdach bdach self-assigned this Sep 23, 2024
bdach added a commit to bdach/osu that referenced this issue Sep 23, 2024
@bdach
Fix argon volume-aware hitsounds not correctly playing immediately af…
e8a394f 
…ter object placement

Closes ppy#29832.

The underlying reason for the incorrect sample playback was an equality
comparer failure.

Samples are contained in several pools which are managed by the
playfield. In particular, the pools are keyed by `ISampleInfo`
instances. This means that for correct operation, `ISampleInfo` has to
implement `IEquatable<ISampleInfo>` and also provide an appropriately
correct `GetHashCode()` implementation. Different audible samples must
not compare equal to each other when represented by `ISampleInfo`.

As it turns out, `VolumeAwareHitSampleInfo` failed on this, due to not
overriding equality members. Therefore, a `new
HitSampleInfo(HitSampleInfo.HIT_NORMAL, HitSampleInfo.BANK_NORMAL,
volume: 70)` was allowed to compare equal to a
`VolumeAwareHitSampleInfo` wrapping it, *even though they correspond to
completely different sounds and go through entirely different lookup
path sequences*.

Therefore, to fix, provide more proper equality implementations for
`VolumeAwareHitSampleInfo`.

When testing note that this issue *only occurs immediately after
placing an object*. Saving and re-entering editor makes this issue go
away. I haven't looked too long into why, but the general gist of it is
ordering; it appears that a `normal-hitnormal` pool exists at point
of query of a new object placement, but does not seem to exist when
entering editor afresh. That said I'm not sure that ordering aspect of
this bug matters much if at all, since the two `IHitSampleInfo`s should
never be allowed to alias with each other at all wrt equality.
@bdach bdach linked a pull request Sep 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdach bdach

Labels
area:editor audio ruleset/osu!taiko
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix argon volume-aware hitsounds not correctly playing immediately after object placement bdach/osu
4 participants
@peppy @bdach @Joehuu @ChromaCat248