Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement beat-synchronized animation in skip overlay #29925

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

nekupaw
Copy link
Contributor

@nekupaw nekupaw commented Sep 18, 2024

I think the new beat-synced animation in the break overlay is really cool, so I implemented pretty much the same approach in the skip overlay.
I also rounded the corners by replacing the box with a circle.

Let me know what you think.

skipOverlay_beat-synced-animation.mp4

@bdach bdach force-pushed the skip-overlay-beat-synced-animation branch from 7e2f647 to fdd94aa Compare September 19, 2024 07:45
@bdach
Copy link
Collaborator

bdach commented Sep 19, 2024

Seems fine? The biggest qualm I'd have is that there's no real guarantee that any beatmap intros or outros are properly timed to the beat, because people just might not have bothered. Not sure how frequent that is.

@nekupaw I fixed your commit message. "publish" is not a good commit message. Please write better ones if you wish to continue contributing.

@peppy Requesting second check on whether we want this at all and whether the visuals look ok.

@bdach bdach requested a review from peppy September 19, 2024 07:46
@peppy
Copy link
Sponsor Member

peppy commented Sep 19, 2024

Not sold on the rounded corners against the hard edge. But this whole overlay will likely be refined in the future™.

@peppy peppy merged commit cd61aec into ppy:master Sep 19, 2024
11 of 13 checks passed
@nekupaw nekupaw deleted the skip-overlay-beat-synced-animation branch September 19, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants