Issue 239: Add flush for event writer #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenqi Mou <[email protected]>
added 2 commits
July 21, 2021 18:50
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
==========================================
+ Coverage 66.37% 72.33% +5.96%
==========================================
Files 43 44 +1
Lines 10717 10848 +131
==========================================
+ Hits 7113 7847 +734
+ Misses 3604 3001 -603
|
tkaitchuck
requested changes
Jul 22, 2021
| /// ``` | ||
| pub async fn write_event(&mut self, event: Vec<u8>) -> oneshot::Receiver<Result<(), Error>> { | ||
| pub async fn write_event(&mut self, event: Vec<u8>) { |
There was a problem hiding this comment.
I don't think we can make this change.
Unlike a byteStream where if one write fails all those after it are sure to fail, and we can resume knowing the offset;
EventStreams have multiple segments, so one event can error while other events before and after can succeed. Similarly the order of acks may be different for different segments.
We can have a flush method, but it does not remove the need for the ack callbacks.
|
Close this as it does not fit anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Add flush for event writer.
Purpose of the change
Fix #239
What the code does
Add a flush method for event writer. Applications use flush to make sure events are persisted in Pravega.
How to verify it
Tests should pass