Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEFAULT_TLS_CERT_PATH should default to /etc/ssl/certs/ca-certificates.crt #379

Open
maddisondavid opened this issue Jul 7, 2022 · 0 comments

Comments

@maddisondavid
Copy link

Problem description
DEFAULT_TLS_CERT_PATH is currently defaulted to ./certs which means that CA certs have to be manually added in order to communicate with the target system.

Problem location

const DEFAULT_TLS_CERT_PATH: &str = "./certs";

Suggestions for an improvement
On most Linux or containerized systems, the system-wide trust store is stored at /etc/ssl/certs/ca-certificates.crt and therefore it makes sense to default to this value so that the Python client may work out of the box. By defaulting to ./certs it guarantees it will never work out of the box without a user manually creating a truststore.

If a user requires a custom trust store or is running on Windows or another Linux distribution, they still have the option of specifying the trust store location using the pravega_client_tls_cert_path environment variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant