Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix result_large_err Clippy error #413

Open
a6dulaleem opened this issue Apr 3, 2023 · 0 comments
Open

Fix result_large_err Clippy error #413

a6dulaleem opened this issue Apr 3, 2023 · 0 comments

Comments

@a6dulaleem
Copy link
Contributor

a6dulaleem commented Apr 3, 2023

Problem description
arning: the Err-variant returned from this function is very large
--> nodejs/src/stream_manager.rs:361:81
|
361 | fn delete_reader_group(&self, scope_name: &str, reader_group_name: &str) -> Result<(), TableError> {
| ^^^^^^^^^^^^^^^^^^^^^^ the Err-variant is at least 128 bytes
|
= help: try reducing the size of pravega_client::sync::table::TableError, for example by boxing large elements or replacing it with Box<pravega_client::sync::table::TableError>
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

How Reproduce
Just run cargo clippy --workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant