Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsm/openrtb #3

Closed
stokito opened this issue Jan 9, 2023 · 3 comments
Closed

bsm/openrtb #3

stokito opened this issue Jan 9, 2023 · 3 comments

Comments

@stokito
Copy link

stokito commented Jan 9, 2023

The https://github.com/bsm/openrtb provides DTOs and is a much popular library (259 stars).
Can you merge code from the library or migrate to it?
bsm/openrtb#94

@SyntaxNode
Copy link
Contributor

This project is maintained by Prebid.org and is used by Prebid Server, among other projects. You are welcomed to use the https://github.com/bsm/openrtb package if you prefer their object model or code styling. Your choice and no hard feelings.

You asked us to merge code from that project. I see in the linked issue reference to ContentCategory. That enumeration is used for the fields bcat, app.cat, site.cat, content.cat, and bid.cat. This project defines these fields as string arrays which is appropriate because the exact enumeration is specified by the cattax field (category taxonomy).

I have no objection to specifying the defined category taxonomy enumerations and keeping the cat fields as a string array. Would that help you in your projects?

@stokito
Copy link
Author

stokito commented Jan 9, 2023

Thank you, I'm not insist just see that we have a duplicated work here.

@SyntaxNode
Copy link
Contributor

Ok. Is there anything else you'd like to discuss on this thread or shall we close the discussion?

@stokito stokito closed this as completed Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants