Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hb_env=amp targeting to AMP #3812

Open
bretg opened this issue Jul 16, 2024 · 4 comments
Open

Add hb_env=amp targeting to AMP #3812

bretg opened this issue Jul 16, 2024 · 4 comments
Labels

Comments

@bretg
Copy link
Contributor

bretg commented Jul 16, 2024

I'm working on the Ad Ops documentation and it would be both easier and more consistent if PBS added hb_env=amp to the targeting for AMP responses.

This is similar to what's done now setting hb_env=mobile-app for PBSDK requests

@muuki88
Copy link

muuki88 commented Jul 17, 2024

You can define static key value targetings in a stored request. This is what we do currently

{
  "id" : "xxxxxxxxxxxxxxxxxxx",
  "ext" : {
    "prebid" : {
      "targeting" : { /* ... */ }
      },
      "integration" : "amp",
      "adservertargeting" : [
       // you can add arbitrary targeting here
        {
          "key" : "hb_source",
          "source" : "static",
          "value" : "s2s"
        }
      ]
    }
  },
  "imp" : [ /* ... */  ],
  "source" : { /* ... */  }
}

@bretg bretg self-assigned this Jul 26, 2024
@bretg bretg moved this from Triage to Needs Requirements in Prebid Server Prioritization Jul 26, 2024
@bretg
Copy link
Contributor Author

bretg commented Sep 5, 2024

I would still like to get approval for PBS to add hb_env=amp for the /amp endpoint.

I don't believe this is a breaking change, nor does it need an option like we did for ext.prebid.targeting.includeformat. hb_env=mobile-app is automatically added when app is in the request.

@bretg bretg moved this from Needs Requirements to Community Review in Prebid Server Prioritization Sep 5, 2024
@bretg
Copy link
Contributor Author

bretg commented Sep 6, 2024

We don't love this, but hb_env already exists. Committee doesn't disapprove. Setting to ready-for-dev.

@bretg bretg moved this from Community Review to Ready for Dev in Prebid Server Prioritization Sep 6, 2024
@bretg bretg removed their assignment Sep 20, 2024
@bretg bretg added the PBS-Go label Sep 20, 2024
@bretg
Copy link
Contributor Author

bretg commented Sep 20, 2024

done with PBS-Java 3.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for Dev
Development

No branches or pull requests

2 participants