Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive and compare iterations.log #440

Open
MakisH opened this issue Jan 15, 2024 · 2 comments
Open

Archive and compare iterations.log #440

MakisH opened this issue Jan 15, 2024 · 2 comments

Comments

@MakisH
Copy link
Member

MakisH commented Jan 15, 2024

In simulations with implicit coupling, the second participant writes a CSV file logging the number of iterations in every coupling time window: https://precice.org/running-output-files.html

We should be checking for regressions in such files, or at least include those in the reference data and reports.

@MakisH MakisH changed the title Compare iterations.log Archive and compare iterations.log Jan 15, 2024
@valentin-seitz
Copy link
Member

So the idea would be to add an option to the yaml to let the users decide to check for that?
I guess we can also make it a bit more abstract and just let the user specify a set list of files that should be the same in terms of binary or textual representation?

@MakisH
Copy link
Member Author

MakisH commented May 11, 2024

I like the suggestion for the more general solution (specify some files to check, either binary or numerical representation). Since we would need to define metrics for the CSV files (rather complicated), let's just check the hashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants