You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #514, I added config visualizations and a script that generates them. I had also added a script that checks if the DOT files were updated after running the visualization script again and which was triggered in the CI.
I had also added the update and check in the pre-commit hook, but since the precice-config-visualizer at that time required additional dependencies for the GUI, which was not possible to disable at that time, decided to not add this to the pre-commit in the end.
After getting an easy-to-install variant of the precice-config-visualizer, we can add this back into the pre-commit.
We I also disagreed with @fsimonis on how to implement the checks in the workflow. While I am also not happy having the automatically generated DOT files in the repository, and while we could generate them in the website CI, I would still like to keep the PNG files in the tutorials repository, because then the README files remain readable offline and on GitHub. The question would be if we can make them reproducible, so that we don't get false alerts to update them.
Commit that removed the checking and CI part: fd9a639
Commit that removed the pre-commit additions: 1e0aea5
The text was updated successfully, but these errors were encountered:
In #514, I added config visualizations and a script that generates them. I had also added a script that checks if the DOT files were updated after running the visualization script again and which was triggered in the CI.
I had also added the update and check in the pre-commit hook, but since the precice-config-visualizer at that time required additional dependencies for the GUI, which was not possible to disable at that time, decided to not add this to the pre-commit in the end.
After getting an easy-to-install variant of the precice-config-visualizer, we can add this back into the pre-commit.
WeI also disagreed with @fsimonis on how to implement the checks in the workflow. While I am also not happy having the automatically generated DOT files in the repository, and while we could generate them in the website CI, I would still like to keep the PNG files in the tutorials repository, because then the README files remain readable offline and on GitHub. The question would be if we can make them reproducible, so that we don't get false alerts to update them.Commit that removed the checking and CI part: fd9a639
Commit that removed the pre-commit additions: 1e0aea5
The text was updated successfully, but these errors were encountered: