Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate updating/checking the config visualizations in the CI #519

Open
MakisH opened this issue Apr 11, 2024 · 0 comments
Open

Integrate updating/checking the config visualizations in the CI #519

MakisH opened this issue Apr 11, 2024 · 0 comments

Comments

@MakisH
Copy link
Member

MakisH commented Apr 11, 2024

In #514, I added config visualizations and a script that generates them. I had also added a script that checks if the DOT files were updated after running the visualization script again and which was triggered in the CI.

I had also added the update and check in the pre-commit hook, but since the precice-config-visualizer at that time required additional dependencies for the GUI, which was not possible to disable at that time, decided to not add this to the pre-commit in the end.

After getting an easy-to-install variant of the precice-config-visualizer, we can add this back into the pre-commit.

We I also disagreed with @fsimonis on how to implement the checks in the workflow. While I am also not happy having the automatically generated DOT files in the repository, and while we could generate them in the website CI, I would still like to keep the PNG files in the tutorials repository, because then the README files remain readable offline and on GitHub. The question would be if we can make them reproducible, so that we don't get false alerts to update them.

Commit that removed the checking and CI part: fd9a639

Commit that removed the pre-commit additions: 1e0aea5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant