Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ONNX Quantisation Support green for “good” (was yellow) [tiny fix] #127

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

emarc
Copy link

@emarc emarc commented Dec 15, 2023

One of the ”good” items (ONNX Quantisation Support) had the yellow dot instead of the 🟢 green. Fixed for clarity.

Review checklist

Don't worry about satisfying all items, it's fine to open a (draft) PR.

  • chapter content
    • only one top-level # h1-Title
    • summary (e.g. table or TL;DR overview), no need for an explicit ## Summary/Introduction title or equivalent
    • main content focus: recent developments in open source AI
      • general context/background (brief)
      • current pros/cons
      • in-depth insights (not yet widely known)
    • likely ## Future developments
    • end with {{ comments }}
  • appropriate citations
    • BibTeX references
    • Glossary terms
    • cross-references (figures/chapters)
    • (if new-chapter.md), add _toc.yml entry & index.md table row
    • If CI URL checks have false-positives, append to _config.yml:sphinx.config.linkcheck*
  • images & data not committed to this repo (e.g. use https://github.com/premAI-io/static.premai.io instead)

One of the ”good” items had the yellow dot instead of the 🟢 green. Fixed for clarity.
Copy link

vercel bot commented Dec 15, 2023

@emarc is attempting to deploy a commit to the Prem Labs Team on Vercel.

A member of the Team first needs to authorize it.

@nsosio nsosio self-requested a review January 8, 2024 13:56
@nsosio nsosio added the bug label Jan 8, 2024
Copy link
Contributor

@nsosio nsosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@nsosio nsosio removed the bug label Jan 8, 2024
@filopedraz
Copy link
Contributor

Please @emarc rebase with main. We have fixed the build pipeline.

@emarc
Copy link
Author

emarc commented Feb 8, 2024

Status: I did this oneliner change straight in the GitHub UI, but to do a rebase I'll have to get back to it later, sorry for the delay. Feel free to do what you see fit (frankly closing this and doing the change again would be faster and easier on the go ;-) ).

@filopedraz
Copy link
Contributor

You can close it and then reopen it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants