-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Premake doesn't set CC variable when generating gsys2 project files (Win10) #1640
Comments
Update: i've checked if issue happens on Linux too, but on latest ZorinOS everything seems to be working fine. |
This looks to be a duplicate of #266? |
So I've had the chance to dig into this. I think it's an easy fix. This is what we currently do to get a tool: function gcc.gettoolname(cfg, tool)
if (cfg.gccprefix and gcc.tools[tool]) or tool == "rc" then
return (cfg.gccprefix or "") .. gcc.tools[tool]
end
return nil
end What I propose is that we change it to this: function gcc.gettoolname(cfg, tool)
local value = gcc.tools[tool]
if type(value) == "function" then
value = value(cfg)
end
return (cfg.gccprefix or "") .. value
end This brings the gcc toolchain to work how the clang toolchain's
@samsinsane @starkos If this is desired behavior, I have this code and corresponding unit tests written up and can put in a PR. |
This looks reasonable to me—thanks for looking into it! |
Sounds good. Let me go ahead an put in the PR |
Wow, did I never put in a PR for this? I'll add this to the top of my todo list for v5. |
hi, is this fixed already? I've noticed that this issue is still open |
What seems to be the problem?
Premake doesn't set the
CC
variable withgmake
andgmake2
generator when trying to build a C projectWhat did you expect to happen?
I expected that i'll be able to build a simple Hello World with barebones premake copied from "Getting Started" guide.
What have you tried so far?
I've managed to build the program after adding
CC = gcc
directly into generated*.make
file.How can we reproduce this?
premake5.lua
example from https://premake.github.io/docs/Your-First-Script and put it alongside the *.c filepremake5 gmake2
mingw32-make
This issue happens when you either
premake5.lua
- fails on build due to lack of CC variable contentWhat version of Premake are you using?
premake5 (Premake Build Script Generator) 5.0.0-alpha16
Anything else we should know?
I've tested it on my personal PC and in a clean virtual machine (both machines have latest Windows 10, MinGW-w64 (x86_64, 8.1.0 and latest Premake). I was able to reproduce the issue on both machines.
The text was updated successfully, but these errors were encountered: