Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newer pupeteer version support #1

Open
janisblaus opened this issue Jul 15, 2020 · 14 comments
Open

Newer pupeteer version support #1

janisblaus opened this issue Jul 15, 2020 · 14 comments

Comments

@janisblaus
Copy link

Hi,

Great work!

Is there a catch that prevents using this to newer versions of puppeteer?

@prescience-data
Copy link
Owner

Not that I know of, I created it for use with Multilogin which is fixed on 2.1.0 but from what I can see it's pretty much the same concept for newer versions. They switched to TS though so the filenames and row numbers etc changed, but all you'd have to do is follow the same changes and then create a patch for your version with https://github.com/ds300/patch-package

@prescience-data
Copy link
Owner

I just created this quick example for 5.2.1 (not tested however, and only modified the CommonJS folder)

https://github.com/prescience-data/harden-puppeteer/blob/master/patches/puppeteer%2B5.2.1.patch

@janisblaus
Copy link
Author

Thanks, will try to follow your example and create a pull request if I will manage to do this successfully. Cheers.

@prescience-data
Copy link
Owner

prescience-data commented Jul 27, 2020

What version do you need it for? Happy to add more versions.

Additionally, if you mirror the changes into a new version, you can test to check if it is working by running the Botcheck.isolatedWorld() test here: https://github.com/prescience-data/puppeteer-botcheck/blob/b6848845b8b5887608784caa2fe7a078db866e9b/Botcheck.js#L45

@janisblaus
Copy link
Author

Im always trying to go with those which has the best stability/feature ratio, at moment its 5.x. Thank you for publishing botchek repo, was thinking to do one as well, this will help me a lot. Will try to contribute some stuff to it as well.

@janisblaus
Copy link
Author

Hey @prescience-data it works like a charm! I owe you a beer! Or even a box of them considering how much I consume from your contributions to the stealth puppeteer lately.

@pkmnmstr98
Copy link

Would the patches made for 5.3 work for the current version of pupp?

@prescience-data
Copy link
Owner

The automatic one won't but what version are you targeting? I'll put up a version for it

@pkmnmstr98
Copy link

7.0.1 If you can 💯 !! Some of the files in 5.3.1 that you changed havent been updated in months

@prescience-data
Copy link
Owner

7.0.1 If you can 💯 !! Some of the files in 5.3.1 that you changed havent been updated in months

Added 💪

@pkmnmstr98
Copy link

Thank you !!!!!

@madagascar253
Copy link

Hey @prescience-data , great work! Can I ask for support to puppeteer version 19.6.2 ?

@GuyFawkesII
Copy link

Hello,
Are there any future plans to update the repository ?

@nwebson
Copy link

nwebson commented Aug 7, 2024

I made a patcher for puppeteer that make similar changes as harden-puppeteer, it runs all code in isolated context instead of the main world.
You can find it here: https://github.com/rebrowser/rebrowser-patches
Thanks to @prescience-data for the original version and inspiration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants