Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receiving warning from React when using firestoreConnect() with React 16.9.0 #236

Closed
braican opened this issue Aug 28, 2019 · 1 comment
Closed

Comments

@braican
Copy link

braican commented Aug 28, 2019

What is the current behavior?

When using the firestoreConnect HOC, I'm receiving a depreciation warning from React in the console:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use.

Screen Shot 2019-08-27 at 6 41 56 PM

The data is getting pulled from Firebase fine.

What is the expected behavior?

To be able to use the firestoreConnect HOC as indicated in the docs and not have it throw a warning in the browser.

Which version of redux-firestore are you using? What about other dependencies?

The warning appears to have been introduced in React 16.9.0. When I revert back to a 16.8.x version of React I don't see the warning.

react: 16.9.0
react-dom: 16.9.0
redux: 4.0.4
react-redux-firebase: 3.0.0-alpha.16
redux-firestore: 0.8.0

Which environments/browsers are affected by this issue? Did this work in previous versions or setups?

Presumably all browsers. As mentioned, the warning is not triggered when using a version of React previous to 16.9.0

Minimal demo to reproduce issue (using codesandbox or similar)

Minimal reproduction here. Open the console to see the warning: https://codesandbox.io/embed/busy-glade-jzh3k

@prescottprue
Copy link
Owner

Thanks for reporting and including the repro. I think this is a duplicate of 755 of react-redux-firebase. Since the HOCs live within that repo, I'll track changes/updates in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants