Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for tree-sitter? #33

Open
lourenci opened this issue Nov 18, 2020 · 9 comments
Open

Support for tree-sitter? #33

lourenci opened this issue Nov 18, 2020 · 9 comments

Comments

@lourenci
Copy link

The title speaks for itself.

Thank you for the colorscheme, I think it's the best light one out there.

@daliusd
Copy link
Contributor

daliusd commented Nov 18, 2020

I looked around a little bit. What tree-sitter has to do with colorscheme? Do you have any example of colorscheme that supports tree-sitter?

@daliusd
Copy link
Contributor

daliusd commented Nov 18, 2020

OK I found one. If you are using tree sitter you can test this color scheme with similar change to this one Iron-E/nvim-highlite@8c0162d and create PR.

@lourenci
Copy link
Author

The colorschemes could leverage the treesitter to keep the colors consistency between the groups, take a look at this. Not to mention that we could ditch polyglot, yats... plugins.

There are already some colors using it.

@daliusd
Copy link
Contributor

daliusd commented Nov 18, 2020

That's fine. If you are using treesitter you are the best person to add support to it ;-)

@lourenci
Copy link
Author

I'll try it.

@alerque
Copy link
Member

alerque commented Nov 18, 2020

I'd be happy to facilitate inclusion of a PR that adds whatever group aliasing is needed for tree-sitter support.It does seem kind of backwards though to generate a bunch of non-standard group names and expect color schemes to adapt. Wouldn't it make more sense to have a tree-sitter option to just alias all the groups to standard names that every color scheme out there already supports?

@daliusd
Copy link
Contributor

daliusd commented Nov 18, 2020

Honestly, my impression is that tree-sitter is doing exactly and many colorschemes just work with it. But it is possible that not all options are covered by standard names and some settings must be added.

@lourenci
Copy link
Author

Honestly, my impression is that tree-sitter is doing exactly and many colorschemes just work with it. But it is possible that not all options are covered by standard names and some settings must be added.

You hit the nail on the head. :)

@alerque
Copy link
Member

alerque commented Nov 18, 2020

If that's what's going on, then fair enough. Like I said I'm quite happy to see it facilitated from the color scheme end if that's what needs to happen, and if somebody contributes the leg work to figure out the right groups to add I'll help get it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants