Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Pressflow 6 LTS still supported? #130

Open
osopolar opened this issue May 31, 2019 · 13 comments
Open

Is Pressflow 6 LTS still supported? #130

osopolar opened this issue May 31, 2019 · 13 comments

Comments

@osopolar
Copy link

osopolar commented May 31, 2019

There is an issue for pressflow6 version from drupal6.49 #127 and a PR #128 for that, but since then nothing happened. Will security updates be ported or would it be better to switch back from pressflow 6 to drupal 6 – is that even possible?

AFAICS there was no database update for switching from Drupal to Pressflow. The project description says:

Each version of Pressflow is API-compatible with the same major Drupal version. For example, Pressflow 6 is compatible with all Drupal 6 modules.

If the site does not use some special Pressflow modules it should be possible to switch back, shouldn't it?

@omega8cc
Copy link

There is always some delay in syncing Pressflow 6 with Drupal 6 LTS, but you can always use our Pressflow 6 fork we maintain for many years, which also includes many improvements in comparison to vanilla Pressflow 6: https://github.com/omega8cc/pressflow6/releases

@osopolar
Copy link
Author

but you can always use our Pressflow 6 fork we maintain for many years, which also includes many improvements in comparison to vanilla Pressflow 6

Thanks @omega8cc, I didn't know about that. Is there any documentation on the differences between omega8cc/pressflow6 and pressflow/6? Is it still API compatible and easy to switch?

@osopolar
Copy link
Author

osopolar commented May 31, 2019

I have done a diff between the last vanilla Pressflow 6 release (pressflow-6.47.127) and the corresponding one from omega8cc (https://github.com/omega8cc/pressflow6/releases/tag/pressflow-6.47.127), there where no differences. After that it looks like the improvements are the changes from d6lts (https://github.com/d6lts/drupal/commits/6.x) to pressflow (omega8cc/pressflow6@6.47.1...pressflow-plus), am I right? Or are there additional changes?

Many thanks for maintaining pressflow and also your work on d6lts.

@pwolanin
Copy link
Contributor

I have been trying to stay in sync with d6lts, but we could probably collaborate better and I'm not actually using this myself currently so it's hard to make it a priority. That project has a pressflow branch that should match this though not exactly the same commits.

@omega8cc
Copy link

omega8cc commented Jun 4, 2019

@osopolar We have started our fork with extensive set of patches recommended by experienced developers maintaining well known modules many years ago (2011). Some have been borrowed later from various D6 distros, because they newer got into vanilla nor Pressflow core. We haven't tracked changes introduced in d6lts, apart from merging releases and patches, but perhaps you have compared vanilla branch and not our customized branch? Here is where it started: https://groups.drupal.org/node/187209

We did the same with our D7 fork, btw: https://groups.drupal.org/node/210683

Yes, both Pressflow 6 and Drupal 7 forks we manage are fully compatible with vanilla core, no API changes, just fixes and improvements.

@omega8cc
Copy link

omega8cc commented Jun 4, 2019

@osopolar Ah, you were comparing the same tags/points in Pressflow and our fork repo. They are obviously identical, because we merge everything, including tags. You should compare our main branch with Pressflow main branch instead.

@dsnopek
Copy link
Contributor

dsnopek commented Jun 5, 2019

Regarding what @pwolanin wrote:

I have been trying to stay in sync with d6lts, but we could probably collaborate better and I'm not actually using this myself currently so it's hard to make it a priority. That project has a pressflow branch that should match this though not exactly the same commits.

We do merge all the D6LTS changes into our own Pressflow fork, but we've diverged a little from upstream Pressflow, and haven't been great about making PR's to merge these back into upstream. Here's the latest branch:

https://github.com/d6lts/pressflow/tree/d-652

I'll try to find some time to figure out our differences with upstream Pressflow and try to get making a PR part of our standard process.

@dsnopek
Copy link
Contributor

dsnopek commented Jun 5, 2019

Here's PR that would sync us up:

#131

@osopolar
Copy link
Author

@omega8cc Do you still maintain Pressflow 6 (https://github.com/omega8cc/pressflow6/issues)?

@omega8cc
Copy link

@osopolar Yes, it's slower than usual, but we will update our fork to sync it with LTS this week.

@omega8cc
Copy link

Yes, our Pressflow fork 6.56.2 has been released. We will make sure it gets any further updates from D6LTS faster.

@osopolar
Copy link
Author

@omega8cc You said on 4 Jun 2019:

Yes, both Pressflow 6 and Drupal 7 forks we manage are fully compatible with vanilla core, no API changes, just fixes and improvements.

I am not sure, what compatibility with vanilla core means, but if you mean exactly the same behavior, it does not. We run into one problem, where an editor disabled a menu item (using og_menu module) can't enable it again due to omega8cc/pressflow6@0a30619

@omega8cc
Copy link

@omega8cc You said on 4 Jun 2019: ...

@osopolar By compatibility we mean API compatibility, not the same behavior, for obvious reasons — many improvements and changes do change behavior — that’s the point of any performance improvement for example. It obviously doesn’t guarantee zero bugs or side effects.

Sent with GitHawk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants