Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-Full Decompilation Cleanup #40

Open
12 tasks
WhenGryphonsFly opened this issue Jan 19, 2024 · 0 comments
Open
12 tasks

Post-Full Decompilation Cleanup #40

WhenGryphonsFly opened this issue Jan 19, 2024 · 0 comments

Comments

@WhenGryphonsFly
Copy link
Collaborator

WhenGryphonsFly commented Jan 19, 2024

Once we have reached 100% code decompilation, some cleanup actions will need to be taken.

  • Resolve remaining NONMATCHING and TODO
  • Find and resolve any fakematches that were not labeled TODO
  • Check duplicate code for the possibility of being an inline function
  • Split c files (such as rom_3219C.c)
  • Split h files (such as functions.h and variables.h)
  • Clean up declarations (e.g., use extern and static as appropriate)
    • Deal with overlapping symbols
  • Ensure when setting IO registers that all fields are specified and are specified in the same order (least to most significant bits?)
  • Establish and follow a style guideline in general
  • Ensure overlapping IO registers use the proper register (see sub_24DC)
  • Ensure proper DMA instructions are used (e.g., DmaCopy16 vs DmaCopy32)
  • Remove magic numbers

Data decompilation and symbol documentation are not on this list, as they will still be calculated by calcrom after 100% code decompilation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant