Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hardware.inc from gbdev, or update hardware_constants.asm #468

Open
Rangi42 opened this issue Sep 24, 2024 · 0 comments
Open

Use hardware.inc from gbdev, or update hardware_constants.asm #468

Rangi42 opened this issue Sep 24, 2024 · 0 comments
Labels

Comments

@Rangi42
Copy link
Member

Rangi42 commented Sep 24, 2024

Right now constants/hardware_constants.asm is very bare-bones, with few constants defined for the values of hardware registers. This means that the code has magic numbers scattered around when setting/checking these values.

We could:

  1. Copy constants from pokecrystal's more complete hardware_constants.asm file.
  2. Use hardware.inc, which is pretty standard in the GB dev community (see also Use hardware.inc from gbdev pokecrystal#914).
  3. Copy some constants from hardware.inc, but use our own file formatting conventions (I'm not a fan of their REGF_VALUE and REGB_VALUE names, or the huge block comments).

In any case, I'd like to sync with the Gen 2 repos on this. (So using hardware.inc directly is probably not the way to go, it would disrupt a lot of existing names.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant