Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "EUROPE" config define? #277

Open
Wack0 opened this issue May 6, 2017 · 2 comments
Open

Add "EUROPE" config define? #277

Wack0 opened this issue May 6, 2017 · 2 comments

Comments

@Wack0
Copy link
Contributor

Wack0 commented May 6, 2017

Some of the code changes being made for German R/S, like bugfixes, apply to all European non-English localisations.

I propose adding something like this to config.h:

#if defined(GERMAN)
#define EUROPE 1
#endif

...then check for the "EUROPE" define for the specific changes / etc that apply for all European non-English localisations.

This should avoid lots of repeated checks for several languages (possibly in several files) in the future.

@camthesaxman
Copy link
Contributor

I think the route we're going with now is to have a #define for each bug fix, and selectively enable them in config.h, and the actual code just uses #ifdef BUGFIX_SOMEBUGFIX instead of checking the language. It doesn't seem any more verbose to do something like this:

#if GERMAN || FRENCH || ITALIAN || SPANISH
#define BUGFIX_SAVEFAILEDSCREEN2
#define BUGFIX_TRAINERAPPROACH
#define BUGFIX_FOO
#define BUGFIX_BAR
//etc
#endif

@marijnvdwerf
Copy link
Contributor

UI-wise, I expect there to be a METRIC/IMPERIAL define as well, ultimately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants