-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration with @stylistic/eslint-plugin #268
Comments
I talked to the creators of ESLint about this, and they said I shouldn’t worry about it. Plugins should recommend a prefix and people should use it. They said it was enough with the disclaimer we have: https://github.com/prettier/eslint-config-prettier#eslintconfigjs-flat-config-plugin-caveat It might be that eslint-config-prettier does not need to support @stylistic/eslint-plugin. It feels like people who use Prettier won’t use that plugin, and people who don’t use Prettier might use it. But if some popular config pulls in that plugin but you prefer Prettier, then I can see it being useful supporting it. Either way – supporting it should be pretty easy I think. Basically copy-paste the core rules and add the prefix. |
Okay great! Yeah that's what I did (adding the rules with |
While migrating my ESLint rules, I have found a single exception to this statement: prettier doesn't cover spaced-comments and suggests to use the ESLint rule instead. |
See #272 |
Per this blog post some style rules are moving from the eslint basic rules to this plugin @stylistic/eslint-plugin
I wonder how this affect the eslint config, since the prettier rules conflicting won't disable rules prefixed from the plugin, especially with the new flat config the prefix can be set arbitrarily.
Example using the plugin in the new flat config and setting the plugin prefix to style:
The text was updated successfully, but these errors were encountered: