Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app depth isn't calculated correctly with only non-JS routes #160

Open
terrablue opened this issue Aug 23, 2024 · 1 comment
Open

app depth isn't calculated correctly with only non-JS routes #160

terrablue opened this issue Aug 23, 2024 · 1 comment
Labels
bug rcompat depends on rcompat changes

Comments

@terrablue
Copy link
Contributor

If routes only contains non-JS files, app depth, which is essential for layout depth calculation, isn't calculated correctly.

for the sake of this fix, @rcompat/fs/router might need to be extended to support several extensions
@terrablue terrablue added rcompat depends on rcompat changes bug labels Aug 23, 2024
terrablue added a commit that referenced this issue Aug 23, 2024
@terrablue
app depth isn't calculated correctly with only non-JS routes #160
1434e51
@terrablue
Copy link
Contributor Author

see also rcompat/rcompat@1f95a56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug rcompat depends on rcompat changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrablue