Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(no-default): removes default normal strategy #452

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

Alexangelj
Copy link
Contributor

@Alexangelj Alexangelj commented Oct 24, 2023

Changelog

  • Removes DEFAULT_STRATEGY state variable in Portfolio contract.
  • Removes using the default strategy if a zero address is passed as a strategy in createPool.
  • Updates the test setup to deploy a normal strategy contract and use it when configuring the portfolio deployment + pools for unit tests.
  • Removes using the non-default/default variables in the Position renderer
  • Pool id encoded the default/non-default strategy info, so we need to decide on how to replace that info with something useful or remove it. For now, it's defaulting to "false", which is a leading 0x0 bit.

@Alexangelj Alexangelj linked an issue Oct 24, 2023 that may be closed by this pull request
@Alexangelj Alexangelj merged commit e92534b into feat/v1.5.0-beta Oct 24, 2023
5 checks passed
@Alexangelj Alexangelj deleted the feat/no-default-strategy branch October 24, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove default strategy
1 participant