Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There might be a lag in between auth and contribute resulting in an error #220

Open
ctrlc03 opened this issue Oct 27, 2023 · 4 comments
Open

There might be a lag in between auth and contribute resulting in an error #220

ctrlc03 opened this issue Oct 27, 2023 · 4 comments
Assignees
@sripwoud
Labels
bug Something isn't working

Comments

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Oct 27, 2023

After authenticating for the first time, the backend creates a user document. There might be a small lag in between the two, and if a user runs the contribute command before the document is created, then the cli might throw an error.
@sripwoud
Copy link
Member

I'll have a closer look next week.
My guess is it is happening here
https://github.com/privacy-scaling-explorations/p0tion/blob/8bb948959ddf324fa7c1633b567ffa9750afc91f/packages/phase2cli/src/commands/contribute.ts#L951C38-L951C38

My current fix idea is:
wrap it in a try/catch
on caught FirebaseError, sleep and retry

@ctrlc03 ctrlc03 added the bug Something isn't working label Oct 27, 2023
sripwoud added a commit to sripwoud/p0tion that referenced this issue Oct 30, 2023
@sripwoud
fix(contribute command): listen to user doc changes instead of fetchi…
4fd942f 
…ng doc to check if exists

There can be some lag after running the auth command before the user can be found in firebase. In
which case trying to fetch the user will fail with `FirebaseError: Unable to retrieve the
authenticated user.`. Instead we can listen and wait for user doc changes.

privacy-scaling-explorations#220
@sripwoud sripwoud mentioned this issue Oct 30, 2023
Closed
8 tasks
@glamperd
Copy link
Contributor

Fixed in #226

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Jul 31, 2024

Fixed in #226

seems like that PR was closed and never merged in?

@ctrlc03 ctrlc03 mentioned this issue Jul 31, 2024
Open
@glamperd glamperd reopened this Aug 1, 2024
@glamperd
Copy link
Contributor

glamperd commented Aug 1, 2024

I'll reopen and revisit this when I get a chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sripwoud sripwoud

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: listen to user doc changes instead of fetching doc to check if exists sripwoud/p0tion
3 participants
@glamperd @sripwoud @ctrlc03