Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Privacy Pass IETF draft as legacy protocol support has been dropped #400

Open
StormProductionsMusic opened this issue Sep 15, 2023 · 11 comments
Labels
bug a reproducible bug next-release v4-rc changes for adopting privacy pass specification

Comments

@StormProductionsMusic
Copy link

Describe the bug
I've just installed PrivacyPass on Brave, and it doesn't want to increase my passes, no mater how much challenges I resolve. I resolved 10 challenges already and it still shows 0 passes.

How to reproduce
Steps to reproduce the behavior:

  1. Install PrivacyPass on Brave;
  2. Resolve a challenge from a supported sie, and see whether your passes are increasing.

Expected behavior
Everytime I solve a challenge, the number of passes should increase and I could redeem them later.

System (please complete the following information):

  • OS: Windows
  • Cloudflare tokens or hCaptcha tokens? hCaptcha
  • Browser: Brave
  • Privacy Pass Version: 3.0.6
@ericpa06
Copy link

ericpa06 commented Sep 18, 2023

I can confirm this bug. It's happening the same thing, And it's not even the first time this extension totally breaks . They will fix eventually, but it might take a few weeks. Honestly, I few they should pay more attention to this project :\

Also, just in case, I'm using Firefox Developer 118 on Windows 10.

@GunGunGun
Copy link

Yeah, because it doesn't get updated regularly it becomes less effective.

@armfazh
Copy link
Member

armfazh commented Oct 2, 2023

An issue on the service has been identified. A major reshape of the extension is in progress.

@StormProductionsMusic
Copy link
Author

An issue on the service has been identified. A major reshape of the extension is in progress.

Are you part of the team? If so, any clue when this new reshape will be released?

@armfazh
Copy link
Member

armfazh commented Oct 4, 2023

Unfortunately, it may take few weeks.

@thibmeu
Copy link
Contributor

thibmeu commented Dec 21, 2023

An update on the current state of the extension:

A library supporting the latest IETF draft has been released on cloudflare/privacypass-ts, and work on the extension is ongoing.

In the meantime, both Cloudflare and hCaptcha moved on from the original Privacy Pass protocol to the IETF version, in the form of supporting Private Attestation Tokens. This improved interoperability and modularity at the protocol level. In addition, it opened the protocol interface to use cases beyond challenge pass, which this extension focused on. I invite you to check the IETF document to understand how this impacts your use cases.

As progress continues, there should be more news about the extension in early 2024.

@thibmeu
Copy link
Contributor

thibmeu commented Jan 8, 2024

A fix to this issue is to upgrade to cloudflare/pp-browser-extension.
Both Cloudflare and hCaptcha stopped providing tokens for Privacy Pass in the form it is implemented by the present repository. They both moved to supporting the latest IETF draft.

Cloudflare is committed to continue experimenting with multiple attestations, and has forked the present repository to keep the development going. The fork allows for multiple attesters to be configured on the user side, without requiring a specific provider template at compilation like the present repository.

At the time of writing, there are no attester replicating the behaviour seen in the legacy protocol: pass one challenge, get thirty tokens. Such an attester could be deployed and configured following the attester template.

@Cuteistfox
Copy link

its early 2023 so any news on adding this to this extension as i dont like silk

@thibmeu
Copy link
Contributor

thibmeu commented Feb 2, 2024

What feature are you looking for?

@Cuteistfox
Copy link

the ietf standard

@thibmeu
Copy link
Contributor

thibmeu commented Feb 2, 2024

Which part of the standard would you like to use that's not implemented by Silk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a reproducible bug next-release v4-rc changes for adopting privacy pass specification
Projects
None yet
Development

No branches or pull requests

6 participants