Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIRM assumes noisy_relations are alphabetically after their clean base_relations #139

Closed
ThomasColthurst opened this issue Aug 5, 2024 · 1 comment
Assignees

Comments

@ThomasColthurst
Copy link
Collaborator

The HIRM constructor calls add_relation for all the relations in the schema using the default map order, which is alphabetical. But add_relation assumes that base_relations are added before any noisy_relations that use them as their base_relations.

Our one HIRM unit test doesn't uncover this, because it uses relation names of the form R[number], and gives higher numbers to the noisy_relations.

@ThomasColthurst
Copy link
Collaborator Author

Fixed in #132

But we will need to keep this in mind when implementing model 6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant