Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow appending a suffix to the URL #203

Open
dhs-rec opened this issue Aug 11, 2022 · 1 comment
Open

Feature Request: Allow appending a suffix to the URL #203

dhs-rec opened this issue Aug 11, 2022 · 1 comment

Comments

@dhs-rec
Copy link

dhs-rec commented Aug 11, 2022

Currently, the text provided after the Smee token in a request is appended to the path given in the -P/--path option. This is working fine for us so far to trigger a Git repository scan in Jenkins using GitLab webhooks. However, the Jenkins Git plugin is changing the rules as newer versions expect an access token to be passed in with the URL, as &token=theToken. This would require us to change ALL webhooks in ALL GitLab repositories that need to trigger a build in Jenkins when we update to a version of the Git plugin that requires the token and, of course, every time we change that token.

An easier way to handle this would be to simply add the token parameter to the URL forwarded to Jenkins by Smee, so here's the request:

Please add a new parameter to Smee client (maybe -s/--suffix) which allows to append additional text to the constructed URL.

@dhs-rec
Copy link
Author

dhs-rec commented Aug 15, 2022

OK, by reading the code I found that I can simply add my own query to the path given with -P/--path, like

... --path /the/path?token=theToken ...

However, it would be nice to have this properly documented somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant