Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta branch - Not supporting special chars in received payload #319

Open
Dancho80 opened this issue Sep 25, 2024 · 2 comments
Open

Beta branch - Not supporting special chars in received payload #319

Dancho80 opened this issue Sep 25, 2024 · 2 comments
Labels

Comments

@Dancho80
Copy link

in case the payload contains some special char like ®, the client fails with error:

TypeError: Cannot convert argument to a ByteString because the character at index 10117 has a value of 8482 which is greater than 255.
at Client.fetch (/smee-client/node_modules/undici/index.js:112:13)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Client.onmessage (file:///smee-client/index.js:52:30)
@wolfy1339 wolfy1339 added the bug label Sep 25, 2024
@wolfy1339
Copy link
Contributor

Can you try changing line 82 so it looks like this

    headers["content-type"] = "application/json; charset=utf-8";

Are you sending the payload as JSON or urlencoded?

@Dancho80
Copy link
Author

Dancho80 commented Sep 26, 2024

same error
my use case: sending Webhooks from GitHub, Content Type = application/json
[EDIT]
if I switch the method from application/json to urlencoded in GitHub Webhook settings
so smee-client is passing the payload but the receiver doesnt accept it with the error 431

org.eclipse.jetty.http.HttpParser parseFields
Header is too large 8193>8192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants