From 6dca528853b1d9b4c87c67ef46261439479f62b2 Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Fri, 30 Aug 2024 18:10:04 +0200 Subject: [PATCH] ci: fix notification workflows used during releases (#3157) The event send by the "npm publish" workflow was incorrect, it didn't correctly integrate the configuration tested in the playground repository. The workflow notifying the R package included 2 issues - the internal action wasn't checkout - the name of the target repository contained a typo The problems above have impacted the release of version `0.44.0`. Running the fixed workflow manually fixed the problems for this particular release. --- .github/workflows/notify-new-version-available-on-npm.yml | 4 +++- .github/workflows/publish-npm.yml | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/notify-new-version-available-on-npm.yml b/.github/workflows/notify-new-version-available-on-npm.yml index b6c5e7e8a3..b359a24d00 100644 --- a/.github/workflows/notify-new-version-available-on-npm.yml +++ b/.github/workflows/notify-new-version-available-on-npm.yml @@ -18,8 +18,10 @@ jobs: strategy: matrix: repository: - - bpmn-visualization-R' + - bpmn-visualization-R steps: + # Need to checkout to access to the internal action + - uses: actions/checkout@v4 - name: Notify that a new bpmn-visualization version is available uses: ./.github/actions/notify-PA-repo-of-new-version with: diff --git a/.github/workflows/publish-npm.yml b/.github/workflows/publish-npm.yml index 48747a2774..724049363c 100644 --- a/.github/workflows/publish-npm.yml +++ b/.github/workflows/publish-npm.yml @@ -23,7 +23,7 @@ jobs: with: # use the default GITHUB_TOKEN, this is possible because we are dispatching the same repository event-type: new_version_available_on_npm - client-payload: '{ "version": "${{ inputs.version }}" }' + client-payload: "{ version: ${{ inputs.version }} }" - name: Send message to Slack channel if: success() uses: slackapi/slack-github-action@v1.26.0