Cannot run npm install
due to dependency conflicts in eslint packages
#2219
Labels
npm install
due to dependency conflicts in eslint packages
#2219
Increasing Access
Currently you cannot run
npm install
to set up the development environment. You must runnpm install --legacy-peer-deps
. This could be confusing to new developers and make it harder to contribute.Feature enhancement details
I'm creating this issue so that I can fix it.
npm install
does not work in this repo right now due to a dependency conflict on theeslint
package. We are usingeslint
version7.31.0
. However we are using an outdated version ofeslint-config-airbnb
which expects a much older version ofeslint
.We have
eslint-config-airbnb@^16.1.0
which expects a peer dependency ofeslint@^4.9.0
. We can fix the conflict by updating theeslint-config-airbnb
package to its latest version which is in the19.x
range -- up 3 major versions. This has not been done previously because updating that package introduces lots of new rules and causes lots of code to fail linting checks. I opened #2217 to discuss the specifics of what new rules we like and don't like. In order to upgrade the package and fix thenpm install
conflict without changing lots of code, I recommend modifying the.eslintrc
config to mimic the current rule conditions. We can then tackle rules one-by-one.The text was updated successfully, but these errors were encountered: