Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run npm install due to dependency conflicts in eslint packages #2219

Open
lindapaiste opened this issue May 22, 2023 · 1 comment · May be fixed by #2220
Open

Cannot run npm install due to dependency conflicts in eslint packages #2219

lindapaiste opened this issue May 22, 2023 · 1 comment · May be fixed by #2220
Labels
Area: Dependencies Pull requests that update a dependency file Enhancement

Comments

@lindapaiste
Copy link
Collaborator

lindapaiste commented May 22, 2023

Increasing Access

Currently you cannot run npm install to set up the development environment. You must run npm install --legacy-peer-deps. This could be confusing to new developers and make it harder to contribute.

image

Feature enhancement details

I'm creating this issue so that I can fix it.

npm install does not work in this repo right now due to a dependency conflict on the eslint package. We are using eslint version 7.31.0. However we are using an outdated version of eslint-config-airbnb which expects a much older version of eslint.

We have eslint-config-airbnb@^16.1.0 which expects a peer dependency of eslint@^4.9.0. We can fix the conflict by updating the eslint-config-airbnb package to its latest version which is in the 19.x range -- up 3 major versions. This has not been done previously because updating that package introduces lots of new rules and causes lots of code to fail linting checks. I opened #2217 to discuss the specifics of what new rules we like and don't like. In order to upgrade the package and fix the npm install conflict without changing lots of code, I recommend modifying the .eslintrc config to mimic the current rule conditions. We can then tackle rules one-by-one.

@lindapaiste lindapaiste linked a pull request May 22, 2023 that will close this issue
4 tasks
@lindapaiste lindapaiste added the Area: Dependencies Pull requests that update a dependency file label Jan 14, 2024
@Sudarshan-21
Copy link

@lindapaiste while running "npm install --legacy-peer-deps" on linux, I am getting this error,
airbnb err1
airbnb err2
airbnb err3
is this something related to my local machine or is there anything I am doing wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Dependencies Pull requests that update a dependency file Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants