Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codemirror to version 6 #2081

Open
kjhollen opened this issue Nov 4, 2022 · 2 comments · May be fixed by #2367
Open

Update codemirror to version 6 #2081

kjhollen opened this issue Nov 4, 2022 · 2 comments · May be fixed by #2367
Labels
Area:Accessibility Category for accessibility related features and bugs Area: Dependencies Pull requests that update a dependency file Enhancement Priority:High

Comments

@kjhollen
Copy link
Member

kjhollen commented Nov 4, 2022

How would this new feature help increase access to the p5.js Editor?

CodeMirror v6 has accessibility support! I'm not sure what else is required to upgrade and activate the accessibility features, but it seems this is built in to the library now.

Feature enhancement details:

According the current package.json file, we're still using CodeMirror 5, which is not compatible with screenreaders. Upgrading to 6.0 or later should fix this.
@kjhollen kjhollen added Area: Dependencies Pull requests that update a dependency file Area:Accessibility Category for accessibility related features and bugs labels Nov 4, 2022
@catarak
Copy link
Member

catarak commented Nov 8, 2022

I actually created a prototype that used CodeMirror 6 a year and a half ago (see the branch feature/codemirror-6-prototype). Probably a good starting point to get it to work with everything that was implemented in CM5!

@lindapaiste lindapaiste mentioned this issue Feb 25, 2023
Open
@lindapaiste
Copy link
Collaborator

I’ve been working on this and making a lot of progress!

I set it up so that the editor only knows about the currently-selected file. When the file is changed then it will change the extensions for language/linting/etc. (which involves using CodeMirror “Compartments” instead of React state updates).

I’m hoping to have something PR-worthy soon but there are still some features that I need to implement. For example I’ve got the search box mostly functional but they don’t have any method that gives you the total result count.

@lindapaiste lindapaiste linked a pull request Aug 8, 2023 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area:Accessibility Category for accessibility related features and bugs Area: Dependencies Pull requests that update a dependency file Enhancement Priority:High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP]: Upgrade Codemirror to v6 lindapaiste/p5.js-web-editor
4 participants
@kjhollen @catarak @lindapaiste @raclim