Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p5 Accesibility error halt execution #803

Closed
limzykenneth opened this issue Jan 13, 2019 · 2 comments
Closed

p5 Accesibility error halt execution #803

limzykenneth opened this issue Jan 13, 2019 · 2 comments

Comments

@limzykenneth
Copy link
Member

limzykenneth commented Jan 13, 2019

Nature of issue?

  • Found a bug

Details about the bug:

The code execution on the page halts because of an error thrown by p5-accessibility.js which doesn't seem to work on Safari.

  • Web browser and version: Safari 12.0.1
  • Operating System: macOS Mojave
  • Steps to reproduce this bug:
    Code to reproduce:
function setup() {
  createCanvas(windowWidth, windowHeight);
}

function draw() {
  background(200)
  rect(0, 0, 20, 50 );
}

Error:

[Error] TypeError: audioCtx.createStereoPanner is not a function. (In 'audioCtx.createStereoPanner()', 'audioCtx.createStereoPanner' is undefined)
	(anonymous function) (p5-accessibility.js:1922)
	(anonymous function)
	draw (about:srcdoc:65)
	redraw (p5.min.js:9:19203)
	(anonymous function) (p5-accessibility.js:1631)
	(anonymous function) (p5-accessibility.js:1847)
	(anonymous function) (p5-accessibility.js:1979)
	(anonymous function) (p5.min.js:8:8386)
	(anonymous function)

Because of #801 it only shows as Script error. (: line 0) on the editor's console, making this error essentially silent for most users. Only happens on Safari when accessibility is enabled.

Maybe this belongs over at p5.accessibility and I'll move it over if so, I have not tried the p5.accessibility on its own outside the web editor. Although it would be great if the error can be caught so that it doesn't halt execution in this case.

@catarak
Copy link
Member

catarak commented Jan 15, 2019

thanks for reporting! i just took a look at the documentation for createStereoPanner and it seems like it's not supported on Safari. i'm going to move this issue over to there, however, yes, this issue does point to the existing issue covered in #801.

@catarak
Copy link
Member

catarak commented Jan 15, 2019

@catarak catarak closed this as completed Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants