From cb241726d09ea409d6274fdc3ba1f46c771ac70e Mon Sep 17 00:00:00 2001 From: Andrii Vysotskyi Date: Thu, 10 Oct 2024 16:59:05 +0200 Subject: [PATCH] Fix tests --- .../Http/UrlSessionHttpConnectorTests.swift | 20 +++++++++---------- .../DefaultCustomerActionsServiceTests.swift | 6 +++++- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/Tests/ProcessOutTests/Sources/Unit/Connectors/Http/UrlSessionHttpConnectorTests.swift b/Tests/ProcessOutTests/Sources/Unit/Connectors/Http/UrlSessionHttpConnectorTests.swift index a8835e573..c332dbcea 100644 --- a/Tests/ProcessOutTests/Sources/Unit/Connectors/Http/UrlSessionHttpConnectorTests.swift +++ b/Tests/ProcessOutTests/Sources/Unit/Connectors/Http/UrlSessionHttpConnectorTests.swift @@ -35,7 +35,7 @@ final class UrlSessionHttpConnectorTests: XCTestCase { // Given let codingError = NSError(domain: "", code: 1234) requestMapper.urlRequestFromClosure = { - throw HttpConnectorFailure.encoding(codingError) + throw HttpConnectorFailure(code: .encoding, underlyingError: codingError) } // When @@ -44,8 +44,8 @@ final class UrlSessionHttpConnectorTests: XCTestCase { ) // Then - if let failure = error as? HttpConnectorFailure, case .encoding(let encodingError) = failure { - XCTAssertEqual(encodingError as NSError, codingError) + if let failure = error as? HttpConnectorFailure, case .encoding = failure.code { + XCTAssertEqual(failure.underlyingError as NSError?, codingError) return } XCTFail("Unexpected result") @@ -66,7 +66,7 @@ final class UrlSessionHttpConnectorTests: XCTestCase { ) // Then - if let failure = error as? HttpConnectorFailure, case .networkUnreachable = failure { + if let failure = error as? HttpConnectorFailure, case .networkUnreachable = failure.code { return } XCTFail("Unexpected result") @@ -85,7 +85,7 @@ final class UrlSessionHttpConnectorTests: XCTestCase { ) // Then - if let failure = error as? HttpConnectorFailure, case .internal = failure { + if let failure = error as? HttpConnectorFailure, case .internal = failure.code { return } XCTFail("Expected internal failure") @@ -107,7 +107,7 @@ final class UrlSessionHttpConnectorTests: XCTestCase { ) // Then - if case let failure = error as? HttpConnectorFailure, case .decoding = failure { + if let failure = error as? HttpConnectorFailure, case .decoding = failure.code { return } XCTFail("Unexpected result") @@ -130,7 +130,7 @@ final class UrlSessionHttpConnectorTests: XCTestCase { ) // Then - if case let failure = error as? HttpConnectorFailure, case .decoding = failure { + if let failure = error as? HttpConnectorFailure, case .decoding = failure.code { return } XCTFail("Unexpected result") @@ -153,7 +153,7 @@ final class UrlSessionHttpConnectorTests: XCTestCase { ) // Then - if case let failure = error as? HttpConnectorFailure, case .decoding = failure { + if let failure = error as? HttpConnectorFailure, case .decoding = failure.code { return } XCTFail("Unexpected result") @@ -176,7 +176,7 @@ final class UrlSessionHttpConnectorTests: XCTestCase { ) // Then - if let failure = error as? HttpConnectorFailure, case let .server(serverError, statusCode) = failure { + if let failure = error as? HttpConnectorFailure, case let .server(serverError, statusCode) = failure.code { XCTAssertEqual(serverError.errorType, "card.invalid-number") XCTAssertEqual(statusCode, 404) } else { @@ -224,7 +224,7 @@ final class UrlSessionHttpConnectorTests: XCTestCase { // Then let error = await assertThrowsError(try await task.value) - if case let failure = error as? HttpConnectorFailure, case .cancelled = failure { + if let failure = error as? HttpConnectorFailure, case .cancelled = failure.code { return } XCTFail("Unexpected result") diff --git a/Tests/ProcessOutTests/Sources/Unit/Service/3DS/DefaultCustomerActionsServiceTests.swift b/Tests/ProcessOutTests/Sources/Unit/Service/3DS/DefaultCustomerActionsServiceTests.swift index 5274cb640..228d7f8f9 100644 --- a/Tests/ProcessOutTests/Sources/Unit/Service/3DS/DefaultCustomerActionsServiceTests.swift +++ b/Tests/ProcessOutTests/Sources/Unit/Service/3DS/DefaultCustomerActionsServiceTests.swift @@ -17,7 +17,11 @@ final class DefaultThreeDSServiceTests: XCTestCase { encoder.outputFormatting = .sortedKeys webSession = MockWebAuthenticationSession() sut = DefaultCustomerActionsService( - decoder: JSONDecoder(), encoder: encoder, jsonWritingOptions: [.sortedKeys], webSession: webSession + decoder: JSONDecoder(), + encoder: encoder, + jsonWritingOptions: [.sortedKeys], + webSession: webSession, + logger: .stub ) threeDSService = Mock3DS2Service() }