feat: Custom C++ namespace for library (#15) #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiz01
reviewed
Sep 13, 2022
leha-bot
added
the
wip
leha-bot
force-pushed
the
feature-custom-ns
branch
2 times, most recently
from
e5f2a53
to
bc11fc5
Compare
Via defining the LB_STD_VERSION_NS macro using the target_compile_definitions(). Its name a bit inconsistent though, but looks better (in my opinion) in C++, but doesn't look OK in a bunch of CMake configure parameters as it conflicts with another flags (`LBSTD_VERSION_xxx` vs `LB_STD_VERSION_xxx`).
For better test cases descriptions.
For CTest statistics / grouping of similar tests. Doctest uses the TEST_SUITE() name for CTest label or the doctest::test_suite() decorator.
leha-bot
force-pushed
the
feature-custom-ns
branch
from
bc11fc5
to
7c3cb8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15.