New GUI Bugs ? and observations

[LazzaAU]

Here is a collection of Bugs and observations found with the new merged GUI. Using firefox on Ubuntu with a RPI3b+ and respeaker 4.

PS: This is not me purposely trying to look for faults, i just happened to have several hours where i could poke and prod :)

Install Issues

Click to expand solved

• jsmin, htmlmin and cssmin don't install on their own and need manually installed

./venv/bin/pip3 install htmlmin

./venv/bin/pip3 install cssmin

./venv/bin/pip3 install jsmin

• nginx needs installed manually

sudo apt-get update

sudo apt-get install nginx

any skill that is causing error , remove it for now untill the skill gets its code updated.

• MqttManager.py was not the correct one. (in process of being fixed ? )

git pull

should be fixed by the time people read this

then restart Alice and potentially she should open on
http::5000 as per normal

Display Issues

Click to expand solved

• Widget screen displays this on Firefox with Dark theme enabled
  

• And similar results with instructions.

• Internet Quality slider and wakeword sensitivity slider no longer display's the "number" of your current setting,

• syslog screen goes black if i refresh the page, no broken heart to indicate that Alice is dead. Assume that's a expected outcome ?

• Downloading a skill from the store then returning to the skills list wont reflect the new skill until page is refreshed. Assume this is expected result but just mentioning :)

• found another display quirk in telemetry skill - cant scroll it, half the view is there, unable to access a save button
  

• Very minor item ....dialogView screen - suggest changing the input box border colour ? on a dark theme the only thing you see is the arrow and a very faint border around the input box.. sit outside like i do often and you don't see the border at all :)

• Miss Aligned text in admin screen - firefox - ubuntu
  
  

My Home

Click to expand solved

• Myhome view zooms out when you scroll down the admin page. refer screen shot posted in #dev https://discord.com/channels/579345007518154752/579365888030015500/804149553552424990

• Not sure how i've managed it yet but i've managed to make certain devices (like Alice) and some locations disappear. Reloading doesnt fix it. zoom can't find them. trying to re add them says they already exist. (will continue to try and narrow down how this happens) --> Assumption by Philipp: they are way of the screen - possibly be cause of fixed errors with nested locations. Closing this bulletpoint until it happens again!

LOG ERRORS

Click to expand solved

- [x] ```File "/home/pi/ProjectAlice/core/base/model/ProjectAliceObject.py", line 117, in broadcast func(**kwargs) File "/home/pi/ProjectAlice/core/util/AliceWatchManager.py", line 90, in onHotwordToggleOff 'text': f'Was asked to toggle itself **off** on device **{self.DeviceManager.getDevice(uid=siteId).displayName}**', AttributeError: 'NoneType' object has no attribute 'displayName' ```

Also get similar with the below

Jan 23 13:00:00 TestAlice python[13507]:     func(**kwargs)
Jan 23 13:00:00 TestAlice python[13507]:   File "/home/pi/ProjectAlice/core/dialog/DialogManager.py", line 59, in onHotword
Jan 23 13:00:00 TestAlice python[13507]:     self.logDebug(f'Wakeword detected by **{self.DeviceManager.getDevice(uid=siteId).displayName}**')
Jan 23 13:00:00 TestAlice python[13507]: AttributeError: 'NoneType' object has no attribute 'displayName'

• Get this error when trying to save admin screen. Happens in both ASR and TTS saving.
  UPDATED COMMENT - The trigger for this is restarting Alice with the admin screen open and not refreshing the page first :)

[ConfigManager]           Trying to get config aliceIp but it does not exist
[ConfigManager]           Was asked to update aliceIp but key doesn't exist
[UtilsApi]                Updating config failed for aliceIp: None
Traceback (most recent call last):
  File "/home/pi/ProjectAlice/core/webApi/model/UtilsApi.py", line 79, in setConfig
    self.ConfigManager.updateAliceConfiguration(conf, value, False)
  File "/home/pi/ProjectAlice/core/base/ConfigManager.py", line 214, in updateAliceConfiguration
    raise ConfigurationUpdateFailed()
core.ProjectAliceExceptions.ConfigurationUpdateFailed: None
[ConfigManager]           Trying to get config aliceVersion but it does not exist
[ConfigManager]           Was asked to update aliceVersion but key doesn't exist
[UtilsApi]                Updating config failed for aliceVersion: None
Traceback (most recent call last):
  File "/home/pi/ProjectAlice/core/webApi/model/UtilsApi.py", line 79, in setConfig
    self.ConfigManager.updateAliceConfiguration(conf, value, False)
  File "/home/pi/ProjectAlice/core/base/ConfigManager.py", line 214, in updateAliceConfiguration
    raise ConfigurationUpdateFailed()
core.ProjectAliceExceptions.ConfigurationUpdateFailed: None

</details>

**NOTE: Have not tested skills and widgets properly until they are all active. Also un able to test voice related stuff due to the displayName error above. Telemetry graph also not tested

[Psychokiller1888]

Skills are reactive, they do appear as installed once Alice has confirmed.

Technically, forget about refreshing, it's a single page app

Re theme, that's, cannot repro as I never use the browser's "turn into dark mode" feature as it brings all these issues

[philipp2310]

Click to expand solved

• DeviceSettings in DeviceTypeDefinition should be obsolete as it is a .template file now?
  
• MyHome: jumping to world center leaves links floating on old position, similar for zooming in or out (until dragging screen when they snap back into position)
• MyHome: Links show over the menu
  
• Scenarios currently linked on fixed ip, not the IP of alice
• startWidgetsOnPage currently run twice with different UIDs?
• Reason unknown so far:
  2021/02/04 22:16:25 [error] 712#712: *10 directory index of "/home/pi/ProjectAlice/core/webui/public/" is forbidden, client: 192.168.0.100, server: _, request: "GET / HTTP/1.1", host: "projectalice:5000"
  Rights look good: drwxr-xr-x 2 pi pi 4096 Feb 4 22:05 public
  --> Folder is empty! requires git pull --recurse-submodules -> required git submodule foreach 'git stash'
• Hidden skill settings are visible
  
• MyHome: No scrolling in device settings possible
• probability threshold has no input:
  
• Widget class instances don't get destroyed when leaving widgets page. reloading widgets page over and over again results for example in the shopping list having multiple updates per second(once scheduled per constructor call). No negative effect spotted apart from long-term performance so far
  maybe outsourcing the call to refresh (as it is a quite common thing) might be a solution as well (in a perfect world with configurable refresh time ;))
• asound.cfg not showing content in admin
• newly paired device won't change status from "not paired" to anything else unless reloaded. In general there is no feedback so far in AliceSatellite when a pairing is done(only logging and reloading of page)
• Telemetry is showing the whole existing device data for every room it has been in once (location not in request???)
• newly created devices seem to be an instance of Device and not the specific device type (clicking starts looking for sat)
• filter dialogView for tags:
• Hidden config values are not hidden (again?) --> example: SupportedLanguages

• widgets don't seem to use the "main" skillInstance but a cached one (onUpdate changes a different instance that affects Voice, but not widget)

Cosmetic:

Click to expand solved

• Switching to Syslog after restart before the UI can do the change results in an error - test: only in dev build? nope
  
• Admin: Filter: not re-inserting categories until everything is removed again
  reproduce: search for: "asr"
  change to "aso" without deleting "as" -> should show asoundConfig, shows nothing
  delete filter, re-enter "aso" and asoundConfig is found again
• The instruction files don't render the html, example is the HA instruction. Was working at least in B4 -> Is using vue-simple-markup, no html supported anymore
• Show current training status in GUI
• resizing the browser while on myHome will cause error logs from leader-line.min.js?3e5b:2 - not reproducable
• manuell inserted Heartbeat is str. instead of int -> device won't load anymore
• MyHome is not scrollable on touch screens

Widgets to update:

• Bring! Shopping List
• OWM
• Satellites
• TextInput
  • SimpleCommand
  • Alice Say
• TextVis

DeviceTypes:

• Satellite
• Vacuum
  • AttributeError: 'DeviceManager' object has no attribute 'getDeviceLinksForSession'
• Zigbee
• HA
• Random IP Device

Improvements:

• maybe hide device links to the parent location as it will get crowded (would include: no link removal to parent location)

[Psychokiller1888]

As a quick morning answer :)

• PairingDone calls saveToDB that calls publishDevice, should update the device on UI, gotta check why not
• Links over menu, yep, saw that, also goes over the header. Very hard to fix
• Device settings scrolling, maybe missing a top container to allow the flex to scroll

[Psychokiller1888]

Just to confirm, yes, device settings can be dropped in definition of the device, but to clarify, settings control the display value, such as X, Y, Z, W, H, R. The config templates are for the configs

[LazzaAU]

not sure if this is the same as phillips "maybe hide device links to the parent location" ?

but when you add ( in my case, 49 devices automatically) and they all end up in the hive by default, then you move them to another location you stay linked to the hive and manually have to click unlink, click icon, click the hive, unclick the unlink icon" then repeat... thats a hell of alot of clicking for 49 devices :)

So i suggest as per previous version, if you move a device to another room, that room becomes parentLocation and the previous room IS NOT automatically linked. That's a user choice.

• done
• Not going to implement

[LazzaAU]

Appears that since the icon changing ability in my home, that

• Adding a device link no longer works ?

• Clicking a device that is NOT a UID of -1 and has a heartbeat, invokes the " Please pair this device" event

• Shifting a device from a location that has a "parentLocation" will cause the icon to get given a coordinate value of negative something, EG: { "x" : -49567, "y" -49321.... } which in return puts it miles off the screen.

• Suggest the notification pop up in "my home" becomes "notification.success" instead of notifications.successes. Successes would be if your referring to the update outcome of ALL devices" success referring to the single device your attempting to update ?. In actual fact a failure is not a success at all so maybe notification.result or something :)... minor detail :)

non linking screenshot

[Psychokiller1888]

When you hover rooms, you get a red outline and hashed locations, which means linking to that loc is not possible ;)

[LazzaAU]

Request with Telemetry tab

I know phil calls it a "concept" but i like the telemetry tab and use it often for monitoring battery levels and tank levels. etc

however couple of small requests if you agree :)

• Can you please make the telemetry Screen scrollable. Or alternatvely able to expand / collapse the buttons and filters area so the graph takes up the screen space. Currently i have to tab at a guess 12 or so times to view the full graph (edited... i just counted and its 30 times ) :)

• We all like color in our life, however personally i think the bright blue of the listed sensors in the filter boxes with the smaller white text is a bit hard to read and suggest more of a contrasting color scheme for those list of sensors, like a darker shade of blue or something with a brighter text maybe ?

?

[philipp2310]

Summary of open points:

• Miss Aligned text in admin screen - firefox - ubuntu --> See first post
  No firefox/ubuntu available at the moment, can't reproduce. --> fixed in new div placement
• widgets don't seem to use the "main" skillInstance but a cached one (onUpdate changes a different instance that affects Voice, but not widget)
• Telemetry screen is not scrollable or resizing in a good way

[philipp2310]

closing this issue - moving the remaining two open points to a better place ;) => #360