Add Type validation for Cluster Configuration Parameters #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ygnas
requested review from
KPostOffice and
Bobbins228
and removed request for
Maxusmusti
Bobbins228
reviewed
Jul 16, 2024
KPostOffice
reviewed
Jul 17, 2024
Ygnas
force-pushed
the
RHOAIENG-9435
branch
6 times, most recently
from
c09a6eb
to
9dc6c56
Compare
KPostOffice
reviewed
Jul 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 9c1e65d
into
project-codeflare:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.redhat.com/browse/RHOAIENG-9435
What changes have been made
Added Type Validation for Parameters
Verification steps
In Cluster Configuration change any of the parameters to a wrong type. Should get an error similar to this:
'num_workers' should be of type <class 'int'>, got listChecks