New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify client calls for machine resources #48

Open

anishasthana opened this issue Mar 30, 2023 · 0 comments

Labels

Contributor

anishasthana commented Mar 30, 2023

We are currently using a large number of api-specific objects to make client calls like get/put / whatever. We should be able to do all of these using the default kubernetes client. https://github.com/opendatahub-io/modelmesh-serving/blob/main/controllers/servingruntime_controller.go#L134-L151 has an example for secrets, but similar logic should function for machinesets and the like.

https://github.com/project-codeflare/instascale/blob/main/controllers/appwrapper_controller.go#L118-L121

anishasthana added the enhancement label

anishasthana mentioned this issue

Use Operator Framework for Instascale controller #64

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment