Allow multiple wallets per subject #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnickelsen
reviewed
Feb 14, 2024
| @@ -154,7 +154,8 @@ public async Task Verify_OnlySingleAllowedPerSubject() | |||
| _options, | |||
| new CreateWalletRequest()); | |||
|
|
|||
| firstCreateResult.Result.Should().BeOfType<CreatedResult>(); | |||
| var firstResponse = firstCreateResult.Result.Should().BeOfType<CreatedResult>() | |||
There was a problem hiding this comment.
Why not spin it up and call via rest?
|
|
||
| var sliceDb = await _certRepository.GetOwnersAvailableSlices(registry, slice.CertificateId, wallet1.Owner); | ||
|
|
||
| sliceDb.Should().HaveCount(1); | ||
| sliceDb.Should().ContainEquivalentOf(slice); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task QueryAvailableCertificates_MultipleWallets() |
There was a problem hiding this comment.
Is this desired? Do we wan't to sum over wallets when querying certificates?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a subject/user in the wallet to create multiple wallets.
All query apis returns results for the subject and not on an individual wallet level.
This is a precursor of future implementations which will enable a user to delegate access to a specific wallet to other users.