Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in real-to-complex FFT example usage (comment) in NE10_dsp.h when directly calling neon implementation #267

Open
michaelkrassowizkiy opened this issue Apr 19, 2021 · 0 comments · May be fixed by #286

Comments

@michaelkrassowizkiy
Copy link

At line 321 in NE10_dsp.h in the comment section of the Real-to-Complex FFT in Example Usage, you would try to call a function that does not exist:

ne10_fft_r2c_cfg_float32_t cfg = ne10_fft_alloc_r2c_float32_neon(fftSize);

Checking in my own project files and looking at the documentation, there is, unlike for the c2c case, no specific neon implementation for getting the configuration structure, i. e. there are are specialized neon (_neon) and c (_c) implementations for ne10_fft_alloc_c2c_float32() [1], but for ne10_fft_alloc_r2c_float32() there are not [2].

[1] https://projectne10.github.io/Ne10/doc/group__C2C__FFT__IFFT.html
[2] https://projectne10.github.io/Ne10/doc/group__R2C__FFT__IFFT.html

I assume this went unnoticed because you usually will not call the specific implementation anyway but, if you for some reason want/need to and are looking for an example, you will likely end up here.

The easiest fix would be just to call the correct (generic) function. Though it might be worth considering to add _c/_neon function pointers pointing at the correct function for consistency, which was probably the reason for this mistake in the first place.

Have a nice day,

Michael

@jpaasen jpaasen linked a pull request Nov 30, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant