Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unreachable branch in local_gva2gpa_common() #8708

Open
haoyu-tang opened this issue Aug 27, 2024 · 1 comment
Open

unreachable branch in local_gva2gpa_common() #8708

haoyu-tang opened this issue Aug 27, 2024 · 1 comment

Comments

@haoyu-tang
Copy link
Contributor

Function local_gva2gpa_common() never run into line 163.

Assume line 163 is reached, then below must be satisfied:
(a) pw_info->is_write_access == true
(b) pw_info->wp == true
(c) fault == 0
(d) is_page_rw_flags_on == false

Conflict:
Line 111 should be reached to satisfy (d).
Line 109 should not be reached to satisfy (c), but it is impossible because of (a) and (b).
@haoyu-tang
Copy link
Contributor Author

[External_System_ID] ACRN-10732

haoyu-tang added a commit to haoyu-tang/acrn-hypervisor that referenced this issue Aug 27, 2024
@haoyu-tang
local_gva2gpa_common: optimize code
82e3a29 
remove unreachable code branch, merge redundant checking.

Tracked-On: projectacrn#8708
Signed-off-by: Haoyu Tang <[email protected]>
@haoyu-tang haoyu-tang mentioned this issue Aug 27, 2024
Merged
haoyu-tang added a commit to haoyu-tang/acrn-hypervisor that referenced this issue Aug 27, 2024
@haoyu-tang
local_gva2gpa_common: optimize code
dd3843a 
remove unreachable code branch, merge redundant checking.

Tracked-On: projectacrn#8708
Signed-off-by: Haoyu Tang <[email protected]>
haoyu-tang added a commit to haoyu-tang/acrn-hypervisor that referenced this issue Aug 27, 2024
@haoyu-tang
local_gva2gpa_common: optimize code
55fa2b8 
remove unreachable code branch, merge redundant checking.

Tracked-On: projectacrn#8708
Signed-off-by: Haoyu Tang <[email protected]>
haoyu-tang added a commit to haoyu-tang/acrn-hypervisor that referenced this issue Aug 30, 2024
@haoyu-tang
local_gva2gpa_common: optimize code
6c3d782 
Remove unreachable code branch in line 163:
if CR0 enabled WP, super-mode writing a read-only page have been
checked in line 109.

Merge redundant checking:
if smap is enabled, supervisor-mode can't access user-mode address
when eflags.ac disabled.

Tracked-On: projectacrn#8708
Signed-off-by: Haoyu Tang <[email protected]>
haoyu-tang added a commit to haoyu-tang/acrn-hypervisor that referenced this issue Aug 30, 2024
@haoyu-tang
local_gva2gpa_common: optimize code
c7493f4 
Remove unreachable code branch in line 163:
if CR0 enabled WP, supervisor-mode writing a read-only page have
been checked in line 109.

Merge redundant checking:
if smap is enabled, supervisor-mode can't access user-mode address
when eflags.ac disabled.

Tracked-On: projectacrn#8708
Signed-off-by: Haoyu Tang <[email protected]>
acrnsi-robot pushed a commit that referenced this issue Aug 30, 2024
@haoyu-tang @acrnsi-robot
local_gva2gpa_common: optimize code
fa1f2ba 
Remove unreachable code branch in line 163:
if CR0 enabled WP, supervisor-mode writing a read-only page have
been checked in line 109.

Merge redundant checking:
if smap is enabled, supervisor-mode can't access user-mode address
when eflags.ac disabled.

Tracked-On: #8708
Signed-off-by: Haoyu Tang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@haoyu-tang