Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make go-tree-sitter optional on unsupported 386 machines #790

Closed
mb01LINX opened this issue Mar 10, 2024 · 3 comments · Fixed by #814
Closed

Make go-tree-sitter optional on unsupported 386 machines #790

mb01LINX opened this issue Mar 10, 2024 · 3 comments · Fixed by #814
Assignees
@RamanaReddy0M
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@mb01LINX
Copy link

mb01LINX commented Mar 10, 2024 •
edited by Mzack9999
Loading

Architectures based on 386 such as CentOS, prevent the binary from being correctly built due to go-tree-sitter cgo constraints. The dependency should be optional via conditional compilation.
@mb01LINX mb01LINX added the Type: Enhancement Most issues will probably ask for additions or changes. label Mar 10, 2024
@Mzack9999 Mzack9999 changed the title need linux386 Make go-tree-sitter optional on unsupported 386 machines Mar 15, 2024
@Mzack9999
Copy link
Member

@mb01LINX Thanks for opening the issue. I've modified it with more details related to the issue.

@mb01LINX
Copy link
Author

Hallo @Mzack9999 Thank you for developing this tool. and can't wait for release of the executable for the 386 architecture. Warm regards.:D

@RamanaReddy0M RamanaReddy0M self-assigned this Mar 20, 2024
@RamanaReddy0M RamanaReddy0M mentioned this issue Mar 20, 2024
Merged
@RamanaReddy0M RamanaReddy0M linked a pull request Mar 20, 2024 that will close this issue
Conditionally include go-tree-sitter in build process #814
Merged
@Mzack9999 Mzack9999 added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Mar 20, 2024
@mb01LINX
Copy link
Author

mb01LINX commented Apr 4, 2024

Hello there! Thanks to this, we can now enjoy the 386 executable.

:BestRegards!~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RamanaReddy0M RamanaReddy0M

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Conditionally include go-tree-sitter in build process projectdiscovery/katana
3 participants
@Mzack9999 @RamanaReddy0M @mb01LINX