Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merklemap? #1368

Open
Barre opened this issue Sep 7, 2024 · 4 comments · May be fixed by #1482
Open

Add merklemap? #1368

Barre opened this issue Sep 7, 2024 · 4 comments · May be fixed by #1482
Assignees
Labels
Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@Barre
Copy link

Barre commented Sep 7, 2024

Hi,

I've been working on Merklemap recently and believe it could be a good fit for this project. Would you be open to me submitting a pull request to integrate its API?

While there isn't comprehensive documentation available yet, I've created a basic CLI for reference: https://github.com/Barre/merklemap-cli

I'd be happy to provide more details or discuss this further if you're interested.

Thanks.

@Barre Barre added the Type: Enhancement Most issues will probably ask for additions or changes. label Sep 7, 2024
@ehsandeep
Copy link
Member

@Barre, nice project!

We're open to adding new sources as long as they add value to the project. In this case, did you find any instances where your project discovered subdomains that weren't being found with the existing sources in Subfinder?

Does your project also include data from sources or methods other than CT Logs, which is already included in Chaos and a few other sources available in Subfinder?

@Barre
Copy link
Author

Barre commented Sep 7, 2024

It does not have any other source, as this project aims to be more of a CT monitor than a pure data finder.

I'd say that the main benefits would be that results are paginatable, unlike crt.sh, and that due to the project's architecture, it shouldn't be overloaded as easily as crt.sh.

One key feature is that we are not doing full text search in the traditional sense so you can perform queries such as *exa*mpl*e* not just the traditional word boundaries.

Let me know if you think it adds enough value or not! :)​​​​​​​​​​​​​​​​

@projectdiscovery projectdiscovery deleted a comment from UNKNOWN0000N Sep 9, 2024
@dogancanbakir
Copy link
Member

@Barre I see no harm in trying it out. Let's include it and make a quick comparison to assess its value -it shouldn't take too much time. Let me know if you need any help!

@Barre
Copy link
Author

Barre commented Sep 15, 2024

Thank you!

I'll try to push a PR this week.

@projectdiscovery projectdiscovery deleted a comment from UNKNOWN0000N Sep 23, 2024
@dogancanbakir dogancanbakir linked a pull request Dec 19, 2024 that will close this issue
@dogancanbakir dogancanbakir self-assigned this Dec 19, 2024
@dogancanbakir dogancanbakir linked a pull request Dec 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants