Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and Fixes to Epstein Civil Violence Model #41

Open
JoeHelbing opened this issue Jun 24, 2023 · 3 comments
Open

Updates and Fixes to Epstein Civil Violence Model #41

JoeHelbing opened this issue Jun 24, 2023 · 3 comments

Comments

@JoeHelbing
Copy link
Contributor

JoeHelbing commented Jun 24, 2023

This is my first public repository issue/pull request. I had mentioned I made these changes a few months ago, but haven't had time until now after the school year is over to clean it up and organize it for a pull request.

These changes fix the lack of cyclical explosions in Citizen agent behavior in the mesa Epstein Civil Violence model with a few tweaks.

Bug Fixes

  • Fix agent state logic
  • Fix Moore vs Von Neuman neighborhood selection to use Epstein paper behavior
  • Fix agent vision bug (was 1 and not parameter vision when calculating neighborhood, which also fixes agent movement issue)
  • Fix arrestee state issue (arrestee was not being reset to "Quiescent", and so was counting as "Active" for all nearby agents)

Additions and Changes

  • add model attributes to count agents and display a graph of agent states
  • Change display of agents where jailed agents are represented by grey square box
  • Added sliders for model attributes
@VinayakPaka
Copy link

I would like to eork on this issue. Can you Please assign this to me.

@EwoutH
Copy link
Member

EwoutH commented Aug 15, 2024

@JoeHelbing thanks for opening the issue! Would you like to work on it yourself, or can I assign it to Vinayak?

@JoeHelbing
Copy link
Contributor Author

JoeHelbing commented Aug 15, 2024

@EwoutH This was integrated into the mesa examples with a pull request already. Sorry, was my first pull request to a public repo (and first issue too) so I think I forgot to update the issue when that pull was merged.

edit not seeing how to close or update this on my side either. If I'm wrong and this wasn't properly merged, I still have the code stored that fixes this above and can redo the pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants