-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue: Full integration of Example models #2364
Comments
I'll pick up the read the docs stuff as discussed today. |
This PR: - Removes the 9 core examples from this repo - Updates the Readme to reflect that. The following examples are moved (to [`examples`](https://github.com/projectmesa/mesa/tree/main/examples)): - Basic Examples - Boltzmann Wealth - Boid Flockers - Conway's Game of Life - Virus on Network - Schelling Segregation - Advanced Examples - Epstein Civil Violence - Sugarscape with Traders - Wolf-Sheep Predation - Demographic Prisoner's Dilemma on Grid Part of projectmesa/mesa#2364.
I'm going to focus on my thesis for a few days, but happy to review anything! |
Just a heads-up that this broke the docs build for the visualization tutorial, because mesa-examples does no longer provide the BoltzmannWealthModel. The vis tutorial does need a larger update anyways (which I somewhere agreed to do), but still this is a major breaking change that we need to communicate somehow. Or maybe easier is to provide the same "model export" in core mesa and then just re-export that from mesa-examples. Thats probably the better path now that I think of it. I'll add "make examples importable" to the checklist |
Curious as to why this needs a discussion? I am strongly in favor of enabling it. Whats a reason against it? |
I just noticed it also. That's just an question of updating the path to import from Let's give @tpike3 a chance to finish his tutorial and then go from there.
Against: It's a lot of work ;). I made an start in #2370. Docstring we should consider if we want to add and require that everywhere. |
I agree its some work but not as bad as what I did a few weeks back with the docstrings. With @Corvince, I believe that we should just enable it and fix all issues. The examples should exemplify good practices. |
@Corvince this means we also have to move them from |
Not sure, I checked and experimented briefly. There is an extensive hatch documentation about file selection From skimming it might be possible from examples, but I don't know if it can automatically be included as "mesa.examples". Someone should figure this out |
@quaquel if you can find the time, having the examples sorted by Basic and Advanced would be really useful, as well as having the Readme descriptions integrated. I'm good with making that whole Readme the starting page for https://mesa.readthedocs.io/latest/examples.html, even if it then looks less good on GitHub (or the links only work on Readthedocs, etc.). Renaming headers etc. is also okay. |
The example level readme is already included. I hope to find some time this weekend to do the overview of examples readme. |
With the core examples being merged back into Mesa in #2358 and now available in
examples
we can now start working our checklist:examples/basic
andexamples/advanced
agents.py
,model.py
andapp.py
pyproject.toml
).from mesa.examples import BoltzmannWealthModel
) (Importable examples #2381)Feel free to add items, and put your name behind something if you want to pick it up!
The text was updated successfully, but these errors were encountered: