Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolaraViz docs #2494

Open
quaquel opened this issue Nov 11, 2024 · 3 comments
Open

SolaraViz docs #2494

quaquel opened this issue Nov 11, 2024 · 3 comments

Comments

@quaquel
Copy link
Member

quaquel commented Nov 11, 2024

SolaraViz creates new model instances via **model_parameters.value. This implies that all inputs for instantiating a new model are keyword arguments. This is currently not well documented, and we might even consider adding this as an explicit check in _check_model_params.

@Corvince
Copy link
Contributor

I agree that this should be documented and added to _check_model_params. Should be a good ticket for new contributors, so I tagged it. But I guess its not a high priority, since this has always been implicitly required (since mesa 0.x days), and as far as reported issues go never been an issue.

@ENUMERA8OR
Copy link
Contributor

@Corvince I would like to contribute to this issue.

@Corvince
Copy link
Contributor

Thats great to hear! Sorry for not responding earlier. If you have any specific question just ask, otherwise I am looking forward to your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants