intro_tutorial: Don't initialize agents with an unique_id #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwoutH
force-pushed
the
intro_tutorial_upgrade
branch
from
b62c30b
to
b8be5fc
Compare
|
Build passed, the updated rendered tutorial can be viewed here (and compared to the current one). It halves the number of warnings from 14 to 7. |
rht
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves about half of the warnings in the intro_tutorial.
The other half is the just replace scheduler, but that's harder to replace, if we also want to rewrite all the explanations.
Maybe we should completely rewrite it.
For now this PR just resolves some warnings.