Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework onPublishComplete #37

Open
jonaskello opened this issue Dec 7, 2021 · 0 comments
Open

Rework onPublishComplete #37

jonaskello opened this issue Dec 7, 2021 · 0 comments

Comments

@jonaskello
Copy link
Member

Today a callback can be sent in for onPublishComplete. In relation to #36 this naming can be confusing as there is no "complete" state in the standard.

However someone that uses the standard could decide that eg. when root.json has no missing dependencies then it is complete. But this decision should be for the application, not something implementing the standard.

So the callback should probably be named something else and be more generic. Perhaps onFilePublished or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant