Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all] added MAINTAINERS.md #5083

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[all] added MAINTAINERS.md #5083

wants to merge 3 commits into from

Conversation

dotdc
Copy link
Member

@dotdc dotdc commented Dec 21, 2024

What this PR does / why we need it

Here's a proposal for MAINTAINERS.md as asked in #5026.
Just kept GitHub handles or forename when I didn't manage to find the full name (maybe it's on purpose):

We can adapt if needed.

cc @RichiH

Which issue this PR fixes

Special notes for your reviewer

Checklist

  • DCO signed
  • [] Chart Version bumped
  • [] Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@dotdc
docs: added MAINTAINERS.md
101b50a 
Signed-off-by: David Calvert <[email protected]>
@dotdc dotdc requested a review from a team as a code owner December 21, 2024 19:51
@dotdc dotdc mentioned this pull request Dec 21, 2024
Open
jkroepke
jkroepke reviewed Dec 21, 2024
View reviewed changes
MAINTAINERS.md Outdated Show resolved Hide resolved
@jkroepke
Copy link
Member

A automation would this would be pretty. Guessing the real name could be fetched via GH API.

@dotdc @jkroepke
Update MAINTAINERS.md
f813b3d 
Co-authored-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: David Calvert <[email protected]>
@dotdc
Copy link
Member Author

dotdc commented Dec 21, 2024

A automation would this would be pretty. Guessing the real name could be fetched via GH API.

True, but we don't add maintainers very often, and not all names are present in GitHub.
We can add a comment in CODEOWNERS eventually.

@jkroepke
Copy link
Member

Could you bump the python version in the CI in a separate PR? At least, I head merge permissions to fix that.

@dotdc
Copy link
Member Author

dotdc commented Dec 22, 2024 •
edited
Loading

Could you bump the python version in the CI in a separate PR? At least, I head merge permissions to fix that.

Created #5085 with Python 3.11

Merged ✔️

@DrFaust92
Copy link
Contributor

On A semi related note, how does one ask for being a maintainer? I would like to offer a hand if I could based on previous contribs

@dotdc
Copy link
Member Author

dotdc commented Dec 22, 2024

On A semi related note, how does one ask for being a maintainer? I would like to offer a hand if I could based on previous contribs

@DrFaust92 Awesome! You should open an issue and PR(s) like #3431.

@DrFaust92 DrFaust92 mentioned this pull request Dec 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkroepke jkroepke jkroepke left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Janitorial] Please add MAINTAINERS.md
3 participants
@dotdc @jkroepke @DrFaust92