smartmon.py won't collect nvme drive metrics

[amigthea]

it only collect sata sd* drives metrics

[dswarbrick]

Did you notice the nvme_metrics.sh in this repo?

[amigthea]

unfortunately no, I totally didn't notice that. But I want to avoid to get two text agent running and scraping the same kind of metrics: smartctl can return metrics for nvme devices as well and that command is used in the smartmon.py script. Could it be possible to edit the code and include nvme devices too? or at least can you please point me where in the python code nvme are filtered out? I'm new to python but I'm willing to learn and edit that by myself

[bjornfor]

FYI, https://github.com/prometheus-community/smartctl_exporter collects metrics for both SATA and NVMe drives.