You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The <route> docs state optional configuration parameters are inherited from its parent node if not set. active_time_intervals and mute_time_intervals are currently copied as part of RouteOps, however they are then overwritten without the nil check that guards other parameters, removing the inheritance. Is this intentional?
The effect is a parent will not implicitly mute its children, e.g. given the following, a and b will still receive every alert all the time:
This tripped us up, as we wanted to notify two receivers with the same mute condition, and the only way to do this is to move the mute down into each child, e.g.
The
<route>
docs state optional configuration parameters are inherited from its parent node if not set.active_time_intervals
andmute_time_intervals
are currently copied as part ofRouteOps
, however they are then overwritten without thenil
check that guards other parameters, removing the inheritance. Is this intentional?The effect is a parent will not implicitly mute its children, e.g. given the following,
a
andb
will still receive every alert all the time:This tripped us up, as we wanted to notify two receivers with the same mute condition, and the only way to do this is to move the mute down into each child, e.g.
If this is intended behaviour, I think it's worth making more explicit in the docs. I'm happy to submit a PR on confirmation.
The text was updated successfully, but these errors were encountered: