Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some recommendations for code readability and security #278

Open
thegostep opened this issue Feb 5, 2021 · 1 comment
Open

Some recommendations for code readability and security #278

thegostep opened this issue Feb 5, 2021 · 1 comment

Comments

@thegostep
Copy link

prettier-solidity/prettier-plugin-solidity#427

@dbale-altoros
Copy link
Collaborator

List to review:

  • don't use contract types in variable declarations
  • declare interfaces in the contract file and override
  • declare all storage variables as private
  • use _ prefix for private / internal references instead of for function parameters
  • organize contract files by access control and state mutability
  • use immutable variables or registry instead of hardcoding addresses
  • move events to interfaces
  • move enums to interfaces
  • use explicit inheritance function references

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants